Skip to content

Update go module to v2 #3660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2025
Merged

Update go module to v2 #3660

merged 2 commits into from
Jul 28, 2025

Conversation

sjberman
Copy link
Collaborator

Problem: With the release of v2.0 of NGINX Gateway Fabric, we need to update the go module version to include /v2, per Go module import standards. Otherwise, NGF cannot be imported past v1.

Solution: Update the module version and all imports to v2.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Update Go module to v2

@github-actions github-actions bot added dependencies Pull requests that update a dependency file chore Pull requests for routine tasks labels Jul 25, 2025
Problem: With the release of v2.0 of NGINX Gateway Fabric, we need to update the go module version to include `/v2`, per Go module import standards. Otherwise, NGF cannot be imported past v1.

Solution: Update the module version and all imports to v2.
@sjberman sjberman force-pushed the chore/update-module branch from 6d1f5d2 to e580cff Compare July 25, 2025 16:43
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.05%. Comparing base (b609534) to head (93ffe72).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3660   +/-   ##
=======================================
  Coverage   87.04%   87.05%           
=======================================
  Files         127      127           
  Lines       15580    15580           
  Branches       62       62           
=======================================
+ Hits        13562    13563    +1     
+ Misses       1859     1858    -1     
  Partials      159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman marked this pull request as ready for review July 25, 2025 17:09
@sjberman sjberman requested a review from a team as a code owner July 25, 2025 17:09
@sjberman sjberman enabled auto-merge (squash) July 28, 2025 17:41
@sjberman sjberman merged commit 9b402b5 into main Jul 28, 2025
43 checks passed
@sjberman sjberman deleted the chore/update-module branch July 28, 2025 17:59
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file release-notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants